-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Environment URL field in Phase model #2392
Adding Environment URL field in Phase model #2392
Conversation
Signed-off-by: vkartik97 <3920286+vkartik97@users.noreply.github.com>
@RishabhJain2018 @rishabhbhardwaj @deshraj @fristonio Please review |
Hey @vkartik97 ! I read your blog and was wondering if you tried this ? |
Yes, this is already enabled in EC2 P2 but I wanted to achieve sharing of GPU resources among the environment containers in multiple pods.
GPU Orchestration on P2 is working as expected, the problem is just the sharing extension. I tried it on 1 node minikube, which didn’t give expected behaviour. |
@vkartik97 I was wondering if this can be used on top of k8s ? It has fractional gpu support and also runs on top of k8s. |
@yashdusing Really thanks for researching on the topic. |
Signed-off-by: vkartik97 <3920286+vkartik97@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
- Coverage 72.74% 72.68% -0.06%
==========================================
Files 82 82
Lines 5316 5327 +11
==========================================
+ Hits 3867 3872 +5
- Misses 1449 1455 +6
Continue to review full report at Codecov.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed as there is no further activity. Thank you for your contributions. |
scripts/seed.py
Outdated
@@ -175,11 +175,15 @@ def create_challenge_phases(challenge, number_of_phases=1): | |||
challenge_phases = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please open up a new PR with the changes in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: #2533
Added
environment_url
field inChallengePhase
model, that is the repository url for environment that will be used by RL Worker.The worker can get the
environment_url
usingapi/challenges/phase/environment/<phase-slug>
.