Add feature to require participants to complete their profile before participating #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…participating - Added boolean field `is_profile_required` in `Challenge` model and updated admin and `ChallengeSerializer` and `ZipChallengeSerializer`. - Updated API `add_participant_team_to_challenge` for checking this field and act accordingly. - Updated `configuration.md` with `is_profile_required` field. - Updated tests
Codecov Report
@@ Coverage Diff @@
## master #2416 +/- ##
=========================================
Coverage ? 74.95%
=========================================
Files ? 78
Lines ? 4980
Branches ? 0
=========================================
Hits ? 3733
Misses ? 1247
Partials ? 0
Continue to review full report at Codecov.
|
galipremsagar
suggested changes
Aug 3, 2019
There was a problem hiding this comment.
I don't see this option in django admin panel. Could you see what it is?
Did you do a fresh docker compose?
Here are list of migrations:
django_1 | Operations to perform:
django_1 | Apply all migrations: account, accounts, admin, auth, authtoken, challenges, contenttypes, django_ses, hosts, jobs, participants, rest_framework_expiring_authtoken, sessions, silk, sites, web
django_1 | Running migrations:
django_1 | Applying contenttypes.0001_initial... OK
django_1 | Applying auth.0001_initial... OK
django_1 | Applying account.0001_initial... OK
django_1 | Applying account.0002_email_max_length... OK
django_1 | Applying accounts.0001_initial... OK
django_1 | Applying accounts.0002_profile... OK
django_1 | Applying accounts.remove_affiliation_model... OK
django_1 | Applying admin.0001_initial... OK
django_1 | Applying admin.0002_logentry_remove_auto_add... OK
django_1 | Applying contenttypes.0002_remove_content_type_name... OK
django_1 | Applying auth.0002_alter_permission_name_max_length... OK
django_1 | Applying auth.0003_alter_user_email_max_length... OK
django_1 | Applying auth.0004_alter_user_username_opts... OK
django_1 | Applying auth.0005_alter_user_last_login_null... OK
django_1 | Applying auth.0006_require_contenttypes_0002... OK
django_1 | Applying auth.0007_alter_validators_add_error_messages... OK
django_1 | Applying auth.0008_alter_user_username_max_length... OK
django_1 | Applying authtoken.0001_initial... OK
django_1 | Applying authtoken.0002_auto_20160226_1747... OK
django_1 | Applying hosts.0001_initial... OK
django_1 | Applying challenges.0001_initial... OK
django_1 | Applying participants.0001_initial... OK
django_1 | Applying participants.0002_participantteam_participantteammember... OK
django_1 | Applying participants.0003_remove_participant_challenge... OK
django_1 | Applying participants.0004_add_created_by_participant_team... OK
django_1 | Applying participants.0005_remove_participantteam_challenge... OK
django_1 | Applying participants.0006_alter_status_participant_choices... OK
django_1 | Applying participants.0007_add_team_participant... OK
django_1 | Applying challenges.0002_challenge_participant_teams... OK
django_1 | Applying challenges.0003_auto_20161203_2258... OK
django_1 | Applying challenges.0004_challenge_is_disabled... OK
django_1 | Applying challenges.0005_changed_phase_model... OK
django_1 | Applying challenges.0006_changed_path_to_upload... OK
django_1 | Applying challenges.0007_rename_test_environment... OK
django_1 | Applying jobs.0001_squashed_0005_upload_unique_random_filename... OK
django_1 | Applying challenges.0008_max_submissions... OK
django_1 | Applying challenges.0009_challengephase_is_public... OK
django_1 | Applying challenges.0010_update_upload_folder_names... OK
django_1 | Applying challenges.0011_approved_by_admin_field_added... OK
django_1 | Applying challenges.0012_added_code_name_field... OK
django_1 | Applying challenges.0013_added_code_name_field... OK
django_1 | Applying challenges.0014_changed_code_name_field... OK
django_1 | Applying challenges.0015_added_dataset_split... OK
django_1 | Applying challenges.0016_added_dataset_split_as_m2m_field... OK
django_1 | Applying challenges.0017_added_leaderboard_table... OK
django_1 | Applying challenges.0018_added_challenge_phase_split_table... OK
django_1 | Applying challenges.0019_added_leaderboard_data_table... OK
django_1 | Applying challenges.0020_alter_challenge_phase_split... OK
django_1 | Applying challenges.0021_remove_challengephase_dataset_split... OK
django_1 | Applying challenges.0022_challengephase_dataset_split... OK
django_1 | Applying challenges.0023_upload_unique_random_filename... OK
django_1 | Applying challenges.0024_added_short_description_field... OK
django_1 | Applying challenges.0025_added_is_submission_pubblic_field... OK
django_1 | Applying challenges.0026_adds_default_field_in_test_annotation... OK
django_1 | Applying challenges.0027_adds_unique_to_codename_dataset_split... OK
django_1 | Applying challenges.0028_zip_configuration_models_for_challenge_creation... OK
django_1 | Applying challenges.0029_add_challenge_star... OK
django_1 | Applying challenges.0030_add_boolean_field_in_star_model... OK
django_1 | Applying challenges.0031_add_db_index_to_challenge_related_models... OK
django_1 | Applying challenges.0032_adds_featured_field_in_challenge... OK
django_1 | Applying challenges.0033_delete_unique_constraint_from_datasetsplit_table... OK
django_1 | Applying challenges.0034_add_allow_block_domain_fields... OK
django_1 | Applying challenges.0035_add_max_concurrent_submissions_allowed_field... OK
django_1 | Applying challenges.0036_Add_unique_random_name_to_challenge_logo... OK
django_1 | Applying challenges.0037_add_field_to_store_forum_url... OK
django_1 | Applying challenges.0038_challenge_remote_evaluation... OK
django_1 | Applying challenges.0039_add_sqs_broker_url_for_challenge_based_worker... OK
django_1 | Applying challenges.0040_change_broker_url_name_to_queue... OK
django_1 | Applying challenges.0041_add_challenge_phase_max_submissions_per_month... OK
django_1 | Applying django_ses.0001_initial... OK
django_1 | Applying hosts.0002_added_unique_attribute_in_team_name... OK
django_1 | Applying hosts.0003_challengehostteam_team_url... OK
django_1 | Applying hosts.Add_blank_in_host_team_URL... OK
django_1 | Applying jobs.0002_path_fix_for_submission_files... OK
django_1 | Applying jobs.0003_added_method_name_field... OK
django_1 | Applying jobs.0004_added_method_desc_aand_urls_to_submission_model... OK
django_1 | Applying jobs.0005_added_new_fields_to_submission_model... OK
django_1 | Applying jobs.0006_add_indexing_to_some_attributes... OK
django_1 | Applying jobs.0007_add_is_flagged_field... OK
django_1 | Applying jobs.0008_remove_indexing_submission... OK
django_1 | Applying jobs.0009_auto_20180629_0334... OK
django_1 | Applying jobs.0010_Add_blank_in_submission_metadata... OK
django_1 | Applying jobs.0011_Change_submission_visibility_default_to_public... OK
django_1 | Applying participants.0008_added_unique_in_team_name... OK
django_1 | Applying participants.0009_participantteam_team_url... OK
django_1 | Applying participants.0010_Add_blank_in_team_URL... OK
django_1 | Applying rest_framework_expiring_authtoken.0001_initial... OK
django_1 | Applying sessions.0001_initial... OK
django_1 | Applying silk.0001_initial... OK
django_1 | Applying silk.0002_auto_update_uuid4_id_field... OK
django_1 | Applying silk.0003_request_prof_file... OK
django_1 | Applying silk.0004_request_prof_file_storage... OK
django_1 | Applying sites.0001_initial... OK
django_1 | Applying sites.0002_alter_domain_unique... OK
django_1 | Applying web.0001_initial... OK
django_1 | Applying web.0002_added_team_model... OK
django_1 | Applying web.0003_added_description_and_background_image_to_team_model... OK
django_1 | Applying web.0004_change_team_model_field_type... OK
django_1 | Applying web.0005_modified_default_attribute_of_visible_field_to_false... OK
galipremsagar
approved these changes
Aug 3, 2019
There was a problem hiding this comment.
LGTM, seems to be some cache issue with docker. Had a fresh setup. @RishabhJain2018 This can be merged.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@Sanji515 Can you please check why this build is failing? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed as there is no further activity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Added boolean field
is_profile_requiredinChallengemodel and updated admin andChallengeSerializerandZipChallengeSerializer.Updated API
add_participant_team_to_challengefor checking this field and act accordingly.Updated
configuration.mdwithis_profile_requiredfield.Updated tests