Update awscli, botocore, boto3 and moto in Travis

[nikochiko]

Reference: #2604
Solve the issue of botocore requirement getting overwritten during travis.

Changes proposed:

• Update awscli, botocore, boto3 and moto to their latest versions

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@3f36692). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2627   +/-   ##
=========================================
  Coverage          ?   73.21%           
=========================================
  Files             ?       82           
  Lines             ?     5338           
  Branches          ?        0           
=========================================
  Hits              ?     3908           
  Misses            ?     1430           
  Partials          ?        0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f36692...e43ae8c. Read the comment docs.

[nikochiko]

Second update:

Only mention awscli in .travis.yml and install awscli's version of botocore

Results:

Build is passing. I added some tests for aws_utils to confirm that the versions are compatible with each other.

Notes:

botocore requirement got overwritten by awscli.
Travis throws this warning:

boto3 1.9.88 has requirement botocore<1.13.0,>=1.12.88, but you'll have botocore 1.14.5 which is incompatible.
boto3 1.9.88 has requirement s3transfer<0.2.0,>=0.1.10, but you'll have s3transfer 0.3.1 which is incompatible.
aws-sam-translator 1.20.1 has requirement jsonschema~=3.0, but you'll have jsonschema 2.6.0 which is incompatible.

[yashdusing]

@nikochiko instead of doing this. Could you try installing awscli and coveralls first.
Then install requirements/dev.txt
and in requirements/dev.txt remove boto3, botocore, moto versions

[nikochiko]

@yashdusing Yes! Doing the same.
Directly making the changes from stackoverflow (https://stackoverflow.com/questions/51911075/how-to-check-awscli-and-compatible-botocore-package-is-installed) is causing pip install to use the boto3 cached during installing from requirements/dev.txt

[yashdusing]

update boto3, botocore, moto in requirements/dev.txt as well

[nikochiko]

Is it okay if the changes are made in requirements/common.txt?
https://github.com/Cloud-CV/EvalAI/blob/master/requirements/common.txt#L2-L3

[yashdusing]

yes.

[yashdusing]

moto should be in dev

[yashdusing]

nvm, since it was in common you can keep it here

[nikochiko]

Okay!

[nikochiko]

I have updated the required deps: awscli, boto3, botocore and moto
I have also verified that they are working by writing some sample aws_utils tests. I think the changes in the PR have been tested well and the fix is working. 👍

I have removed the additional tests now.

[nikochiko]

As pointed out by @yashdusing the reason the travis build was failing was because the tests in submission_worker were creating an actual boto3 object and not one mocked with moto. This was solved by moving the mock_sqs decorator to base class.

[yashdusing]

LGTM 👍

[yashdusing]

@Ram81 @vkartik97 @Sanji515 @RishabhJain2018 please review 😄

[Ram81]

LGTM 👍

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This pull request has been automatically closed as there is no further activity. Thank you for your contributions.