Show error message when downloading submissions that has > 5k results

[gautamjajoo]

When downloading results for a phase that has > 5k results, an error is shown to use the get_all_submissions API to download the results.

Also, removed the code where we are fetching the number of submissions of the participant Team on all-submissions page since we do not need it here.

@Ram81 @Kajol-Kumari

[codecov-commenter]

Codecov Report

Merging #3442 (b8a6047) into master (96968d6) will decrease coverage by 0.49%.
The diff coverage is 34.80%.

@@            Coverage Diff             @@
##           master    #3442      +/-   ##
==========================================
- Coverage   72.93%   72.44%   -0.50%     
==========================================
  Files          83       20      -63     
  Lines        5368     3175    -2193     
==========================================
- Hits         3915     2300    -1615     
+ Misses       1453      875     -578     

Impacted Files	Coverage Δ
frontend/src/js/controllers/authCtrl.js	53.91% <6.38%> (-12.95%)	⬇️
frontend/src/js/controllers/profileCtrl.js	79.76% <20.00%> (-13.10%)	⬇️
frontend/src/js/controllers/permissionCtrl.js	36.36% <22.22%> (-63.64%)	⬇️
frontend/src/js/controllers/challengeCtrl.js	65.17% <33.64%> (-8.52%)	⬇️
frontend/src/js/controllers/updateProfileCtrl.js	82.55% <44.44%> (-10.30%)	⬇️
frontend/src/js/controllers/challengeListCtrl.js	95.74% <50.00%> (+1.06%)	⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js	70.50% <66.66%> (-1.18%)	⬇️
frontend/src/js/controllers/teamsCtrl.js	71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js	100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js	95.45% <100.00%> (ø)
... and 30 more

Impacted Files	Coverage Δ
frontend/src/js/controllers/authCtrl.js	53.91% <6.38%> (-12.95%)	⬇️
frontend/src/js/controllers/profileCtrl.js	79.76% <20.00%> (-13.10%)	⬇️
frontend/src/js/controllers/permissionCtrl.js	36.36% <22.22%> (-63.64%)	⬇️
frontend/src/js/controllers/challengeCtrl.js	65.17% <33.64%> (-8.52%)	⬇️
frontend/src/js/controllers/updateProfileCtrl.js	82.55% <44.44%> (-10.30%)	⬇️
frontend/src/js/controllers/challengeListCtrl.js	95.74% <50.00%> (+1.06%)	⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js	70.50% <66.66%> (-1.18%)	⬇️
frontend/src/js/controllers/teamsCtrl.js	71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js	100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js	95.45% <100.00%> (ø)
... and 30 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e6c2d...b8a6047. Read the comment docs.

[Kajol-Kumari]

Minor changes required, rest Looks good to me 👍

[Kajol-Kumari]

Can we please revert this change as it's required for this PR

[gautamjajoo]

We were using this url on the submissions page, but this was confusing whether it was for all submissions or submissions for a particular team that's why I have modified it to make it more descriptive.

[Ram81]

@gautamjajoo we should show this in a card on the All submissions page instead of a toast. You can highlight the card after the user clicks on the Download button. We will show the card on the page even if the download button is not clicked as a note if the number of submissions is > 5k. Let me know if you have doubts.

[gautamjajoo]

@Ram81 The card would be like the Submission Guidelines one above the Make Submission which is on the submit page

[gautamjajoo]

Results > 5k

Results < 5k

[Ram81]

@gautamjajoo can you fix the message card style. It doesn't look consistent with other cards that we show to hosts on the challenge page.

[gautamjajoo]

@Ram81 Updated card:

[Ram81]

@gautamjajoo can you increase the top, bottom and left padding for the message. For style reference you can create a new challenge on frontend v1 and go to challenge overview page to see how we show instructions currently.

[gautamjajoo]

@Ram81 @Kajol-Kumari

[Ram81]

LGTM