Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add challenge queue name and pk in manage tab #3831

Merged
merged 4 commits into from Dec 5, 2022

Conversation

gchhablani
Copy link
Collaborator

This PR adds challenge queue name and primary key on the Manage tab (only visible to host).

An example is shown below:

image

@gchhablani
Copy link
Collaborator Author

The command '/bin/sh -c bower install --allow-root' returned a non-zero code: 1
ERROR: Service 'nodejs' failed to build : Build failed

Build is failing for the PR because of the above error. Not sure why.

@gchhablani
Copy link
Collaborator Author

gchhablani commented Nov 12, 2022

  • Move the section below the submission worker controls.
  • Add headline "Remote Evaluation Meta".
  • Mention only "Primary Key" and "Queue Name"

@gchhablani
Copy link
Collaborator Author

Screen Shot 2022-11-12 at 3 39 55 PM

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #3831 (f2b1191) into master (96968d6) will decrease coverage by 1.34%.
The diff coverage is 34.87%.

@@            Coverage Diff             @@
##           master    #3831      +/-   ##
==========================================
- Coverage   72.93%   71.59%   -1.35%     
==========================================
  Files          83       20      -63     
  Lines        5368     3242    -2126     
==========================================
- Hits         3915     2321    -1594     
+ Misses       1453      921     -532     
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 63.59% <32.16%> (-10.11%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/profileCtrl.js 80.89% <45.45%> (-11.96%) ⬇️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/challengeListCtrl.js 95.74% <80.00%> (+1.06%) ⬆️
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 69 more
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 63.59% <32.16%> (-10.11%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/profileCtrl.js 80.89% <45.45%> (-11.96%) ⬇️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/challengeListCtrl.js 95.74% <80.00%> (+1.06%) ⬆️
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def9fb7...f2b1191. Read the comment docs.

@Ram81 Ram81 merged commit 0cc3596 into Cloud-CV:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants