Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with AvgPooling layer padding calculation #391

Open
Ram81 opened this issue Oct 23, 2018 · 10 comments
Open

Fix issue with AvgPooling layer padding calculation #391

Ram81 opened this issue Oct 23, 2018 · 10 comments

Comments

@Ram81
Copy link
Member

Ram81 commented Oct 23, 2018

Goal of the issue is to fix the bug in padding calculation logic for pooling layers. Due to miscalculation of padding shapes of layers are miscalculated leading to failure in model exports and wrong parameter calculation.

@bikram99
Copy link

Hello I am Bikram.I would like to work with on this issue,would you tell me where to start?

@Ram81
Copy link
Member Author

Ram81 commented Oct 24, 2018

@bikram99 you can start by setting up development environment of Fabrik. For starters you can look into code in ide/utils. Before that it would be good to understand how Fabrik works by looking into flow of components.

@bikram99
Copy link

@Ram81 ,hello I looked at the code in ide/utils.Would you tell me the path of the file to look into for the AvgPooling layer?
Sorry,actually I couldnt find it . :)

@Ram81
Copy link
Member Author

Ram81 commented Oct 27, 2018

@bikram99 the logic to calculate shapes of layers is in ide/utils/shapes.py

@namish800
Copy link

@Ram81 I would like to work on this issue. Can you tell me How to reproduce this issue?

namish800 added a commit to namish800/Fabrik that referenced this issue Dec 12, 2018
@Gurpreetsingh9465
Copy link

can i work on this issue

@namish800
Copy link

namish800 commented Dec 19, 2018

@Gurpreetsingh9465 I am already working on this issue.

@Gurpreetsingh9465
Copy link

Ok nimish

@Mayukhdeb
Copy link

Goal of the issue is to fix the bug in padding calculation logic for pooling layers. Due to miscalculation of padding shapes of layers are miscalculated leading to failure in model exports and wrong parameter calculation.

how do I replicate this issue on my machine ?

@aksharma53
Copy link

#391 still unsolved or not ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants