Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Extended Support for Layer Import for TF and keras (#293) #296

Merged
merged 6 commits into from Feb 4, 2018

Conversation

Ram81
Copy link
Member

@Ram81 Ram81 commented Jan 29, 2018

@utsavgarg please review.

@coveralls
Copy link

coveralls commented Jan 29, 2018

Coverage Status

Coverage decreased (-0.05%) to 95.442% when pulling 171c3ff on Ram81:TF-Import-Support into 40b9510 on Cloud-CV:master.

@Ram81 Ram81 changed the title Fix: Add Support for LRN Layer in tensorflow import(#293) Fix: Extended Support for Layer Import for TF and keras (#293) Feb 4, 2018
Copy link
Contributor

@utsavgarg utsavgarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall :)

if (layer.concat_param.axis is not None):
params['axis'] = layer.concat_param.axis
else:
# default value for axis of dropout in caffe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this related to dropout?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I accidentally wrote dropout there it should be concat

@utsavgarg utsavgarg merged commit bcc8459 into Cloud-CV:master Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants