Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting multiple layers issue #317 #485

Closed
wants to merge 23 commits into from
Closed

Deleting multiple layers issue #317 #485

wants to merge 23 commits into from

Conversation

Gurpreetsingh9465
Copy link

This is a PR regarding issue #317

  1. multiple layer selection
  2. deletion
  3. confirmation
  4. improved the logic of tracking nextlayer
  5. making sure the the default select layer method does not conflict with this

@Gurpreetsingh9465 Gurpreetsingh9465 changed the title Deletetion of multiple layers issue #317 Deleting multiple layers issue #317 Dec 3, 2018
@Gurpreetsingh9465
Copy link
Author

Right click selects the layer

@yashdusing
Copy link
Contributor

yashdusing commented Dec 4, 2018

A few issues I've encountered :

  1. If side panel is enabled, selection is not possible.
  2. Selection of layer could be highlighted using some different css techniques. Something like blurring would be good imo. First discuss with @Ram81 about the css.
  3. All caps for the deletion message. Again, consult @Ram81 about this
  4. After deleting a number of layers, the last remaining layer does not track next layer i.e. layer addition does not append layer to last layer

@Gurpreetsingh9465
Copy link
Author

Right now the code is in a way that If sidepane is enabled then you can't select or deselect layers further and the the sidepanel layer is deselected.

@Gurpreetsingh9465
Copy link
Author

The new layer is appending I guess you can see it on the .gif as well can you send me the console output

@yashdusing
Copy link
Contributor

Sorry, I was a little busy. Here you go.
screenshot_20181208_004938

@yashdusing
Copy link
Contributor

Steps to recreate :

  1. Load ZFnet
  2. Select random layers from the middle and then delete these layers
  3. Then select one of the 2 remaining sets and delete it.
  4. Now try adding layers

@yashdusing
Copy link
Contributor

Also, please do something about the css. It's hard to keep track of the selected layers

@Gurpreetsingh9465
Copy link
Author

test
updated the css

Copy link
Member

@Ram81 Ram81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gurpreetsingh9465 can you please remove the changes for adding Vnect to model zoo from this PR. Don't add redundant code

README.md Outdated Show resolved Hide resolved
ide/static/js/canvas.js Outdated Show resolved Hide resolved
added " " after :
added " " after :
added " " after :
@Gurpreetsingh9465
Copy link
Author

Changes done.

Copy link
Member

@gautamjajoo gautamjajoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the image of vnect model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants