Added export functionality for Keras #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
utsavgarg
commented
Jun 26, 2017
utsavgarg
commented
- Added functions to calculate output shapes for Keras export
- Added Data, Conv, Pool, Activation, Dense, Flatten, Dropout layers
- Tested export of VGG-16
* Added Conv, Input, Pooling, Activation, Dropout and Dense layers * Tested export of VGG-16
* Added support for BatchNorm and Eltwise layers
* Added concat layer * Fixed bug with zero padding layer
* Added Reshape and Deconv layers
* Added support for LSTM, SimpleRNN layers * Added documentation in __init__.py
virajprabhu
requested changes
Jun 30, 2017
| @@ -27760,7 +27760,7 @@ | |||
| delete netData[layerId].state; | |||
| }); | |||
There was a problem hiding this comment.
Not sure what you meant here
There was a problem hiding this comment.
I meant we should add bundle.js to gitignore.
| elif(net[layerId]['info']['type'] == 'Reshape'): | ||
| net[layerId]['shape']['output'] = reshape(net[layerId]) | ||
|
|
||
| elif(net[layerId]['info']['type'] in ['SPP', 'Crop']): |
There was a problem hiding this comment.
We should throw a "This layer is not supported in Keras" error on the front end for this.
There was a problem hiding this comment.
Okay will add exception handling.
| params['kernel_w'], params['kernel_h'] = layer.kernel_size | ||
| params['stride_w'], params['stride_h'] = layer.strides | ||
| params['pad_w'], params['pad_h'] = get_padding(params['kernel_w'], params['kernel_h'], | ||
| params['kernel_h'], params['kernel_w'] = layer.kernel_size |
There was a problem hiding this comment.
Was this a mistake in the earlier PR?
|
The |
|
Great, please add everything that you've tested to the examples folder. Would be good to make subfolders for each framework. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.