Support for new keras layers #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed `setParams` to allow greying out parameters * Added a flag to each parameter value to indicate whether to disable or not * Added 1D and 3D conv options to conv dropdown * Modified shape calculation to handle different dimensional data * Added import and export of Conv1D and Conv3D to keras support
* Added MaxPooling1D, MaxPooling3D, AveragePooling1D, AveragePooling3D, GlobalMaxPooling1D, GlobalAveragePooling1D * Added ZeroPadding1D, ZeroPadding3D
* Added ThresholdedReLU, selu, softplus, softsign and hard sigmoid
* GaussianNoise, GaussianDropout, AlphaDropout
virajprabhu
reviewed
Jul 19, 2017
| @@ -185,7 +185,7 @@ class Canvas extends React.Component { | |||
| layer.connection = { input: [], output: [] }; | |||
| layer.params = {}; | |||
| Object.keys(data[type].params).forEach(j => { | |||
| layer.params[j] = data[type].params[j].value; | |||
| layer.params[j] = [data[type].params[j].value, false]; | |||
There was a problem hiding this comment.
Comment mentioning that true maps to disabled?
There was a problem hiding this comment.
Its there in content.js line 287
| @@ -185,7 +185,7 @@ class Canvas extends React.Component { | |||
| layer.connection = { input: [], output: [] }; | |||
| layer.params = {}; | |||
| Object.keys(data[type].params).forEach(j => { | |||
| layer.params[j] = data[type].params[j].value; | |||
| layer.params[j] = [data[type].params[j].value, false]; | |||
| }); | |||
| // l.props = JSON.parse(JSON.stringify(data[type].props)); | |||
There was a problem hiding this comment.
its required I think
| } | ||
| }); | ||
| if (type == 'Convolution' || type == 'Pooling' || type == 'Upsample' || type == 'LocallyConnected' || type == 'Eltwise'){ | ||
| layer = this.adjustParameters(layer, 'layer_type', layer.params['layer_type'][0]); | ||
| } | ||
| // layer.props = JSON.parse(JSON.stringify(data[type].props)); |
There was a problem hiding this comment.
you want to send all layers to adjustParameters ?
There was a problem hiding this comment.
Nevermind, some issue with the review interface
There was a problem hiding this comment.
Nevermind, some issue with the review interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.