Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #114:(Redirect to a blank page) #116

Merged
merged 4 commits into from
Jan 11, 2018
Merged

Fixed #114:(Redirect to a blank page) #116

merged 4 commits into from
Jan 11, 2018

Conversation

vpn1997
Copy link
Member

@vpn1997 vpn1997 commented Jan 4, 2018

Solved the error of #114 .

@coveralls
Copy link

coveralls commented Jan 4, 2018

Coverage Status

Coverage increased (+0.03%) to 88.076% when pulling 4cbce7b on vpn1997:fix3 into 9141501 on Cloud-CV:master.

@PalashTanejaPro
Copy link

Successfully tested!

@AvaisP
Copy link
Member

AvaisP commented Jan 5, 2018

Can you explain why this fixes it and why we were having the issue?

@vpn1997
Copy link
Member Author

vpn1997 commented Jan 5, 2018

We are having this issue because allauth requires unique email id per user.So if we are having a user with with same emailid as that of our github account in our database( by creating a superuser with same emailid before registering through github ) and then we try to register through our github account,then there will be 2 users with same emailid and causes ambiguity .By setting Unique emailid=False,it changes that setting and now we are allowed to have different users with same emailid .But all these conflicts only happens during development phase because in the deployment phase , the only authentication method is through github and github by default needs a unique email id per user.So that fix will only work for debugging phase(where conflict happens). 😄 @AvaisP

@AvaisP
Copy link
Member

AvaisP commented Jan 8, 2018

Sounds good. Will review it within 24 hours

@@ -167,6 +167,8 @@
}

SITE_ID = 1
if(DEBUG):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the parenthesis?

Copy link
Member Author

@vpn1997 vpn1997 Jan 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just my way of writing code 😄 .I can change it if you want me to. @AvaisP

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please change 😄

@vpn1997
Copy link
Member Author

vpn1997 commented Jan 11, 2018

@AvaisP done 😄

@coveralls
Copy link

coveralls commented Jan 11, 2018

Coverage Status

Coverage increased (+1.9%) to 89.934% when pulling 3451a05 on vpn1997:fix3 into 9141501 on Cloud-CV:master.

@AvaisP AvaisP merged commit 745c0b0 into Cloud-CV:master Jan 11, 2018
@vpn1997 vpn1997 changed the title Fixed #114 Fixed #114:(Redirect to a blank page) Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants