-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #114:(Redirect to a blank page) #116
Conversation
Successfully tested! |
Can you explain why this fixes it and why we were having the issue? |
We are having this issue because allauth requires unique email id per user.So if we are having a user with with same emailid as that of our github account in our database( by creating a superuser with same emailid before registering through github ) and then we try to register through our github account,then there will be 2 users with same emailid and causes ambiguity .By setting Unique emailid=False,it changes that setting and now we are allowed to have different users with same emailid .But all these conflicts only happens during development phase because in the deployment phase , the only authentication method is through github and github by default needs a unique email id per user.So that fix will only work for debugging phase(where conflict happens). 😄 @AvaisP |
Sounds good. Will review it within 24 hours |
django_server/settings.py
Outdated
@@ -167,6 +167,8 @@ | |||
} | |||
|
|||
SITE_ID = 1 | |||
if(DEBUG): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the parenthesis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just my way of writing code 😄 .I can change it if you want me to. @AvaisP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please change 😄
@AvaisP done 😄 |
Solved the error of #114 .