made copyright year dynamic #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikhilmudholkar Can you please resolve the conflicts here? |
gautamjajoo
reviewed
Feb 12, 2019
docs/index.html
Outdated
| @@ -420,7 +420,7 @@ <h4 class="code-container-style"><b>View stats of your hosted challenge with ID | |||
| </div> | |||
| <p id="footer-margin"> | |||
| Maintained by the EvalAI core team | |||
| <br> ©2019 EvalAI | |||
| ©<script>new Date().getFullYear()&&document.write(new Date().getFullYear());</script> EvalA | |||
There was a problem hiding this comment.
I think there is no need to add the
tag. I have tried adding it, it makes no change in the display
There was a problem hiding this comment.
By adding br tag, ©2019 EvalAI will come on the next line!
There was a problem hiding this comment.
It's anyway coming on the next line. I'll change it if you say so
docs/index.html
Outdated
| @@ -420,7 +420,7 @@ <h4 class="code-container-style"><b>View stats of your hosted challenge with ID | |||
| </div> | |||
| <p id="footer-margin"> | |||
| Maintained by the EvalAI core team | |||
| <br> ©2019 EvalAI | |||
| ©<script>new Date().getFullYear()&&document.write(new Date().getFullYear());</script> EvalA | |||
There was a problem hiding this comment.
Done. So irresponsible of me to forget it. Sorry mate
gautamjajoo
approved these changes
Feb 12, 2019
RishabhJain2018
approved these changes
Feb 16, 2019
|
@nikhilmudholkar Can you please resolve the conflicts? |
|
Done @RishabhJain2018 |
Ram81
pushed a commit
to Ram81/evalai-cli
that referenced
this pull request
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #131 : made the copyright year dynamic. Also instead of manually writing the copyright symbol which might face rendering issues in different text editors, used © for displaying the same symbol