Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrates origami-lib with TravisCI #8

Merged
merged 1 commit into from Dec 4, 2017
Merged

Integrates origami-lib with TravisCI #8

merged 1 commit into from Dec 4, 2017

Conversation

idealadarsh
Copy link
Contributor

@idealadarsh idealadarsh commented Dec 4, 2017

Adds a .travis.yml file and runs some script to install the library.
No tests are currently there so it just installs origami-lib for now.

Fix:
#4

My fork:
https://github.com/idealadarsh/origami-lib

Travis build:
https://travis-ci.org/idealadarsh/origami-lib/builds/311200222

Related GCI task:
https://codein.withgoogle.com/dashboard/task-instances/4717290908024832/

@AvaisP
Copy link
Member

AvaisP commented Dec 4, 2017

#6 added tests. Please make sure Travis is running the tests

@idealadarsh
Copy link
Contributor Author

Thanks! Will do that.

@idealadarsh
Copy link
Contributor Author

@AvaisP Tests run now.

@AvaisP
Copy link
Member

AvaisP commented Dec 4, 2017

@idealadarsh Please fix the travis build. It is failing

@idealadarsh
Copy link
Contributor Author

@AviasP Did you check the builds?
They are failing because tests are running.
Tests are throwing errors, I don't know who wrote those tests and how to fix them.

But this issue is solved.
Travis is integrated and tests are running.

@AvaisP
Copy link
Member

AvaisP commented Dec 4, 2017

Please read the instructions to run the tests here https://github.com/Cloud-CV/origami-lib/blob/master/origami-lib/test/README.md . You aren't running the server

@idealadarsh
Copy link
Contributor Author

@AvaisP Sorry I didn't see that. Please wait a minute

@idealadarsh
Copy link
Contributor Author

idealadarsh commented Dec 4, 2017

@idealadarsh
Copy link
Contributor Author

@AvaisP It is giving same error when I ran those tests locally as in travis.
Here's the log: https://pastebin.com/ScCVvyh6

@AvaisP
Copy link
Member

AvaisP commented Dec 4, 2017

Check the comment on the task

@AvaisP
Copy link
Member

AvaisP commented Dec 4, 2017

Great job! Suggesting a few changes

language: python

python:
- "2.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it not run with python 3.4+?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create a task for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

.travis.yml Outdated
apt:
packages:
- python-dev
- python-numpy
Copy link
Member

@AvaisP AvaisP Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you installing numpy and opencv by apt and then by pip?

- cd origami-lib/test/
- pytest

cache: pip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always end your file with a new line

@idealadarsh
Copy link
Contributor Author

@AvaisP No it fails with python3.4, check this build: https://travis-ci.org/idealadarsh/origami-lib/builds/311379467


script:
- cd origami-lib/test/
- pytest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please shut the server after script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind. I'll make that a different task

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me for now

@AvaisP AvaisP merged commit 3940a59 into Cloud-CV:master Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants