New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrates origami-lib with TravisCI #8
Conversation
#6 added tests. Please make sure Travis is running the tests |
Thanks! Will do that. |
@AvaisP Tests run now. |
@idealadarsh Please fix the travis build. It is failing |
@AviasP Did you check the builds? But this issue is solved. |
Please read the instructions to run the tests here https://github.com/Cloud-CV/origami-lib/blob/master/origami-lib/test/README.md . You aren't running the server |
@AvaisP Sorry I didn't see that. Please wait a minute |
@AvaisP Please check this build, |
@AvaisP It is giving same error when I ran those tests locally as in travis. |
Check the comment on the task |
Great job! Suggesting a few changes |
language: python | ||
|
||
python: | ||
- "2.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it not run with python 3.4+?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will create a task for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
.travis.yml
Outdated
apt: | ||
packages: | ||
- python-dev | ||
- python-numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you installing numpy and opencv by apt and then by pip?
- cd origami-lib/test/ | ||
- pytest | ||
|
||
cache: pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always end your file with a new line
@AvaisP No it fails with python3.4, check this build: https://travis-ci.org/idealadarsh/origami-lib/builds/311379467 |
|
||
script: | ||
- cd origami-lib/test/ | ||
- pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please shut the server after script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind. I'll make that a different task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me for now
Adds a .travis.yml file and runs some script to install the library.
No tests are currently there so it just installs origami-lib for now.
Fix:
#4
My fork:
https://github.com/idealadarsh/origami-lib
Travis build:
https://travis-ci.org/idealadarsh/origami-lib/builds/311200222
Related GCI task:
https://codein.withgoogle.com/dashboard/task-instances/4717290908024832/