userinfo: add list-group subcommand. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cviecco
reviewed
Feb 5, 2021
| "github.com/Cloud-Foundations/golib/pkg/auth/userinfo/gitdb" | ||
| ) | ||
|
|
||
| func getDB(source string, logger log.DebugLogger) (*gitdb.UserInfo, error) { |
There was a problem hiding this comment.
what does this function is supposed to be doing? From the name it is not clear its differnce from gitdb.New.
There was a problem hiding this comment.
It's a convenience wrapper to remove some boilerplate. It handles creating a temporary directory where the repository is copied to if the repository is remote and if the repository is local it passes that in to the underlying function.
The underlying function is designed to periodically git pull. The CLI doesn't need that, it just was a one-off fetch.
There was a problem hiding this comment.
I've tweaked the documentation.
cviecco
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.