Add self-service Bootstrap OTP generation. #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cviecco
requested changes
Jun 12, 2020
cmd/keymasterd/2fa_bootstrapOTP.go
Outdated
| state.logger.Printf("error generating Bootstrap OTP: %s", err) | ||
| return | ||
| } | ||
| duration := time.Minute * 5 |
| @@ -111,6 +111,44 @@ func (state *RuntimeState) BootstrapOtpAuthHandler(w http.ResponseWriter, | |||
| } | |||
| } | |||
|
|
|||
| func (state *RuntimeState) trySelfServiceGenerateBootstrapOTP(username string, | |||
There was a problem hiding this comment.
I dont like the signature of this function, it should return a bool if successful, otherwise we cannot distingusish sucess from failure... and thus as it is right now there is a race condition where the otp generated but fails to be added to the DB.
Thus on the caller you can do
selfServiceOtpGenerated := state.trySelfServiceGenerateBootstrapOTP.....
I really dislike logic where updates to object are not explicitly communicated.
There was a problem hiding this comment.
I've changed the function signature. The caller hasn't changed because there isn't really anything it would do differently regardless of the return status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.