Bug fix: Check for valid E57 pose rotation #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgirardeau
reviewed
Sep 28, 2022
| @@ -1399,6 +1399,10 @@ static bool GetPoseInformation(const e57::StructureNode& node, ccGLMatrixd& pose | |||
| bool validPoseMat = false; | |||
| if (node.isDefined("pose")) | |||
| { | |||
| CCCoreLib::SquareMatrixd rotMat(3); | |||
There was a problem hiding this comment.
Is it necessary do that here since 'validPoseMat' is false? You could simply call 'validPoseMat.toIdentity()' at the beginning of the method, just in case.
There was a problem hiding this comment.
I was considering the case that translation is defined, but not rotation. Seems reasonable to initialise to identity matrix, in the absence of rotation?
There was a problem hiding this comment.
Yes it's enough to initialize poseMat to identity directly.
There was a problem hiding this comment.
Updated as discussed.
dgirardeau
approved these changes
Sep 29, 2022
|
Thanks! |
|
Cheers! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloudCompare seems to be having trouble reading E57 that have a pose rotation quaternion set to all zeros.
Likely this is malformed according to the E57 specification, but this change adds a check.
See also: libE57Format #107