qPCL: add support for (u)int64 pcd field types #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelH91
commented
Feb 12, 2024
SamuelH91
commented
- update dependencies in conda.yml
- PCL 1.13.1 supports int64 and uint64 field types
- PCL dependency from vtk forced also to update ffmpeg
- qAnimation: update QVideoEncoder to use newer ffmpeg API
- update dependencies in conda.yml - PCL 1.13.1 supports int64 and uint64 field types - PCL dependency from vtk forced also to update ffmpeg - qAnimation: update QVideoEncoder to use newer ffmpeg API
|
Hey. That's interesting, but this PR doesn't compile on my side (with FFMPEG 4.3 and PCL 1.12). While I can upgrade to FFMPEG 6.1 easily, would it be possible to add some preprocessors to keep the compatibility with PCL 1.12? @rjanvier @prascle Would moving to FFMPEG 6.1 work on your Linux and macOS builds? (edit: not for the 2.13 release ;) ) |
|
Apparently you have forced compilation with Qt5.15, which is not supported yet |
|
For the records, the QVideoEncoder part of this PR was merged here: #2006 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.