Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on archs where char is unsigned #783

Closed
wants to merge 1 commit into from

Conversation

frediz
Copy link

@frediz frediz commented Sep 20, 2018

For that specific source file, just add -fsigned-char for compilation.
This closes #709.

For that specific source file, just add -fsigned-char for compilation.
This closes CloudCompare#709.
@asmaloney
Copy link
Member

Does this change have any consequences for the code in ChamferDistanceTransform.cpp or are you just trying to "get it to compile"?

Adding a specific compile flag for one file is a Bad Idea. If there's a problem with that one file then it should be addressed properly.

@frediz
Copy link
Author

frediz commented Sep 20, 2018

It was an implementation of the proposal done here : #709 (comment)
Since the code just expects signed char from what I see, it just tells gcc to use signed chars which corresponds to what the code needs.
A better solution would just be to be more precise and be explicit and use signed char instead of char.
And I actually see that this has been done on master (I was checking the logs provided in the bug)...
but the bug #709 has not been closed then.
So, sorry for the noise, nothing to be done.
Thanks for your time.

@frediz frediz closed this Sep 20, 2018
@frediz frediz deleted the fix-709 branch September 20, 2018 13:37
@asmaloney
Copy link
Member

No problem!

Thanks for taking the time to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian package fails to build for some architectures
2 participants