Merge pull request #59 from CloudHeads/bugfix/add-test-fo-empty-event

Add tests for empty events to prevent exceptions

lambda_utils/logger/sentry.py

@@ -29,7 +29,7 @@ def add_user_context(self, event):
             for key, value in event['requestContext']['authorizer'].items():
                 user_context[key.lower()] = value
             self.client.user_context(user_context)
-        except KeyError:
+        except (KeyError, TypeError):
             logging.debug("No user  context recognized in event['requestContext']['authorizer']")
 
     def add_x_ray_tags(self, event):

lambda_utils/response_handlers/api_gateway.py

@@ -13,7 +13,8 @@
 
 class ApiGateway(BaseResponseHandler):
     def on_execution(self, event):
-        event['body'] = extract_body(event)
+        if type(event) is dict:
+            event['body'] = extract_body(event)
         return event
 
     def on_exception(self, ex):

tests/logger/test_sentry.py

@@ -46,6 +46,12 @@ def test_add_user_context_set_client_context(self, client_mock, event):
 
         client_mock.user_context.assert_called_once_with({'key': 'value'})
 
+    @patch.object(logging, 'debug')
+    def test_add_user_context_with_none_event(self, debug_mock, event):
+        Sentry().add_user_context(None)
+
+        debug_mock.assert_called_once()
+
     @patch.object(module.Sentry, 'client')
     def test_add_x_ray_tags_adds_requester_trace_id(self, client_mock, event, x_amzn_trace_id):
         Sentry().add_x_ray_tags(event)

tests/response_handlers/test_api_gateway.py

@@ -17,6 +17,11 @@ def test_on_execution_calls_extract_body(self, extract_body_mock):
         extract_body_mock.assert_called_once_with(event)
         assert_that(result, equal_to({'body': extract_body_mock.return_value, 'some': 'event'}))
 
+    def test_on_execution_calls_with_none_event(self):
+        result = ApiGateway().on_execution(None)
+
+        assert_that(result, equal_to(None))
+
     def test_on_timeout_exception(self):
         result = ApiGateway().on_exception(ex=TimeoutError())