Sampling #307
Sampling #307
Conversation
…src ip, dst ip, protocol) of a receiving packet 2. if a port receives multiple packets with the same 3-tuple assume they are part of same context and increment count. 3. if the packet count of same context greater than 15, drop the packer otherwise forward the packet 4. Overall, using a 3-tuple to maintain context information can be a useful tool for managing network traffic and ensuring that packets are delivered to their intended destinations.
removed print statements
There was a problem hiding this comment.
The binary sampling file should not be included in the commit.
Need to add sampling/sampling binary file to the cndp/lang/go/.gitignore file and remove the binary from the commit.
| @@ -227,8 +229,10 @@ func GetIPv4(pkt *Packet) *IPv4Hdr { | |||
|
|
|||
| if pkt != nil { | |||
| ether := GetEtherHdr(pkt) | |||
|
|
|||
| //fmt.Println("ethernet Header", ether) | |||
There was a problem hiding this comment.
Need to remove the commented out code debug code from the commit.
| @@ -0,0 +1,17 @@ | |||
| Brief Description about Sampling Go Apllication | |||
There was a problem hiding this comment.
Convert this file from a README to a doc.go file. This allows us to use the document tools to display this type of information, which is something needed for other Go code and will create an issue. Make sure the copyright notice is correct with the current year only.
| }, | ||
| "fwd:1": { | ||
| "group": "group1", | ||
| "lports": ["eno12399:0"], |
There was a problem hiding this comment.
Having two threads manage the same port should not be done. The transmit side of CNDP has protection from two or more threads accessing the same netdev/qid, but the receive side does not have that protection. Normally we have only one thread doing receives on a given netdev/qid, but that thread can send to any other netdev/qid port to allow forwarding of packets.
Unless the example requires two I would remove the second thread for now, but it really needs to be able to handle more than one netdev/qid devices.
| "bufcnt":64, | ||
| "bufsz": 2, | ||
| "mtype": "2MB", | ||
| "regions": [ |
There was a problem hiding this comment.
If you remove the second thread and because only one netdev/qid was defined in the lports section, please also change the regions from "regions": [32, 32], to "regions":[64],
| @@ -0,0 +1,159 @@ | |||
| { | |||
There was a problem hiding this comment.
This file should be named sampling.jsonc not sampling.jsnoc
There was a problem hiding this comment.
I am still reviewing this PR, but I had a few quick comments.
I noticed the DCO or Signed-off-by lines are missing in one of more commits in this PR. We require all commits to contain this line in the commit message. If you click on the Details link in the Conversation tab where the tests are run it will explain how to correct this problem.
Fix up the json file to remove second thread and umem region. Signed-off-by: Keith Wiles <keith.wiles@intel.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Sampling Application uses 3-tuple to maintain context information can be a useful tool for managing network traffic and ensuring that packets are delivered to their intended destinations.
Which issue(s) this PR fixes:
Issue: #223
Signed-off-by: Vikas Jain vikas.jain@intel.com
Signed-off-by: Vijaya Tiruveedula vijaya.tiruveedula@intel.com