Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Chinese language. #515

Merged
merged 10 commits into from
Jul 25, 2021
Merged

Added Chinese language. #515

merged 10 commits into from
Jul 25, 2021

Conversation

Score2
Copy link
Contributor

@Score2 Score2 commented Jul 10, 2021 •
edited
Loading

This pull request includes:

  • breaking changes
  • no breaking changes

Changes made to the repository:

  • Added Chinese language.

Documentation of test results:

  • All tests passed

derklaro
derklaro requested changes Jul 10, 2021
View reviewed changes
Copy link
Member

@derklaro derklaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test your code in the runtime before submitting a pull request. This change can't work...

cloudnet-wrapper-jvm/src/main/java/de/dytanic/cloudnet/wrapper/Main.java Outdated Show resolved Hide resolved
cloudnet/src/main/java/de/dytanic/cloudnet/Main.java Outdated Show resolved Hide resolved
@derklaro derklaro added the s: blocked Please do not merge, the pull request is not ready yet / waiting for something which is required label Jul 10, 2021
@Score2
Copy link
Contributor Author

Score2 commented Jul 10, 2021

Please test your code in the runtime before submitting a pull request. This change can't work...

Sorry, I was negligent, it has been revised now.:)

@Score2 Score2 changed the title Added chinese language. Added Chinese language. Jul 11, 2021
@derklaro
Copy link
Member

You see, i don't speak chinese but i see minor changes every commit - can you please validate that this pull request is ready for review?

@Score2
Copy link
Contributor Author

Score2 commented Jul 12, 2021

You see, i don't speak chinese but i see minor changes every commit - can you please validate that this pull request is ready for review?

It seems that there may be some problems at present, I will try to improve these translations in the next few commits.

@Score2
Copy link
Contributor Author

Score2 commented Jul 12, 2021

You see, i don't speak chinese but i see minor changes every commit - can you please validate that this pull request is ready for review?

I have reviewed and improved the translation many times, and the current changes have been perfect.:)

derklaro
derklaro approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@derklaro derklaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @0utplay can you please verify aswell?

@derklaro derklaro changed the base branch from development to dev/3.5 July 24, 2021 17:28
0utplay
0utplay requested changes Jul 25, 2021
View reviewed changes
Copy link
Member

@0utplay 0utplay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert some changes

cloudnet-wrapper-jvm/src/main/resources/lang/chinese.properties Outdated Show resolved Hide resolved
cloudnet/src/main/resources/lang/chinese.properties Outdated Show resolved Hide resolved
@0utplay
Copy link
Member

0utplay commented Jul 25, 2021

LGTM

@derklaro derklaro merged commit e973b94 into CloudNetService:dev/3.5 Jul 25, 2021
@Score2 Score2 mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0utplay 0utplay 0utplay requested changes

@derklaro derklaro derklaro approved these changes

Assignees
No one assigned
Labels
s: blocked Please do not merge, the pull request is not ready yet / waiting for something which is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Score2 @derklaro @0utplay