fix: correctly bind plugin instance to bungee plugin injector #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
added
v: 4.X
0utplay
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current platform plugin manager for bungeecord incorrectly binds the instance of a plugin to the parent injector instead of the specified injector that is used to construct the plugin instance. This leads to the problem, that the instance passed to the plugin classes is always the plugin instance of the first constructed plugin, not of the current plugin.
Modification
Correctly bind the plugin instance to the injector responsible for the current plugin instead of the parent injector.
Result
BungeeCord plugins that are using platform inject are now receiving the correct plugin instance, instead of the instance of the first constructed plugin.