fix: allow repetition of jvm options and command line arguments #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
approved these changes
Mar 15, 2023
derklaro
added
v: 4.X
derklaro
changed the title
0utplay
approved these changes
Mar 17, 2023
|
Thanks! |
derklaro
pushed a commit
that referenced
this pull request
Apr 17, 2023
### Motivation On my server I wanted to add the following JVM Options: "--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED", but noticed that duplicated elements e.g. "--add-opens" were removed automatically and thus this was not possible. ### Modification I've modified the eu.cloudnetservice.driver.service.ProcessConfiguration Class to use a LinkedList instead of a LinkedHashSet ### Result Now duplicated Elements in the jvmOptions and processParameters will now accept duplicated elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On my server I wanted to add the following JVM Options: "--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED", but noticed that duplicated elements e.g. "--add-opens" were removed automatically and thus this was not possible.
Modification
I've modified the eu.cloudnetservice.driver.service.ProcessConfiguration Class to use a LinkedList instead of a LinkedHashSet
Result
Now duplicated Elements in the jvmOptions and processParameters will now accept duplicated elements.