fix: added missing methods = "POST" in V2HttpHandlerService inside the Rest Module #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
approved these changes
Mar 18, 2023
derklaro
added
v: 4.X
derklaro
pushed a commit
that referenced
this pull request
Apr 17, 2023
…ather than GET (#1166) ### Motivation I wanted to use the api for example create a service from a task but noticed that it tries to return information of a service that does not exists. ### Modification I marked the handleCreateRequest method that it takes only http POST requests rather than GET requests to prevent overlapping with other http handlers. ### Result Now you can create services from a task with the HTTP route again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I wanted to use the api for example create a service from a task but noticed that it tries to return information of a service that does not exists.
Modification
I marked the handleCreateRequest method that it takes only http POST requests rather than GET requests to prevent overlapping with other http handlers.
Result
Now you can create services from a task with the HTTP route again.