Removed that the task template is configured in the group configuration #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mlunkeit <malte.lunkeit@gmail.com>
derklaro
approved these changes
Apr 9, 2023
derklaro
pushed a commit
that referenced
this pull request
Apr 17, 2023
…s well (#1175) ### Motivation We found in the group configuration that it contains the template of the tasks (created on the initial setup). I asked on the Discord if this were a bug, because the template were already on the task configuration and that it shouldn't be there was confirmed by: 0utplay#0187 (https://discord.com/channels/325362837184577536/818777626663321671/1089277611378753597) ### Modification I've modified the DefaultTaskSetup class to not include the template of the task to the group ### Result Now the template of the tasks (created on the initial setup) will not be inside the group configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We found in the group configuration that it contains the template of the tasks (created on the initial setup). I asked on the Discord if this were a bug, because the template were already on the task configuration and that it shouldn't be there was confirmed by: 0utplay#0187 ( https://discord.com/channels/325362837184577536/818777626663321671/1089277611378753597 )
Modification
I've modified the DefaultTaskSetup class to not include the template of the task to the group
Result
Now the template of the tasks (created on the initial setup) will not be inside the group configuration.
Other context
I've added "mlunkeit" as co-contributor in the commit because we discovered it together.
Fixes #