-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve the default signs layout #1230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
This pull should be included in the 4.0 release
t: improvement
The pull request improves existing code
in: module
An issue/pull request releated to one of the internal modules
labels
May 15, 2023
Test Results 47 files ±0 47 suites ±0 1m 8s ⏱️ -8s Results for commit f55b831. ± Comparison against base commit 05236d2. This pull request removes 15 and adds 15 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
derklaro
requested changes
May 16, 2023
...gns/src/main/java/eu/cloudnetservice/modules/signs/configuration/SignConfigurationEntry.java
Outdated
Show resolved
Hide resolved
...gns/src/main/java/eu/cloudnetservice/modules/signs/configuration/SignConfigurationEntry.java
Outdated
Show resolved
Hide resolved
...gns/src/main/java/eu/cloudnetservice/modules/signs/configuration/SignConfigurationEntry.java
Outdated
Show resolved
Hide resolved
...gns/src/main/java/eu/cloudnetservice/modules/signs/configuration/SignConfigurationEntry.java
Outdated
Show resolved
Hide resolved
derklaro
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: module
An issue/pull request releated to one of the internal modules
t: improvement
The pull request improves existing code
v: 4.X
This pull should be included in the 4.0 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When creating a new sign config entry a default sign layout is set. The default layout is not really nice and does not showcase what you can do with our signs.
Modification
Changed the global layout to look like the per targetGroup layout and also made sure to use %task% instead of a fixed name like
Lobby
to ensure correct names on the signs.Result
New better looking signs.