Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the floating item to null if the material is air #1249

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented Jun 9, 2023

Motivation

When trying to remove the floating item of a npc using the material "air" the armor stand becomes visible and some of our infolines disappear.

Modification

Converted the air material to null to make sure that no item is displayed.

Result

No item is displayed when using AIR and all armor stands are still correct

@0utplay 0utplay added v: 3.X This pull should be included in the 3.4 release t: fix A pull request introducing a fix for a bug. in: module An issue/pull request releated to one of the internal modules labels Jun 9, 2023
@0utplay 0utplay added this to the 4.0.0-RC9 milestone Jun 9, 2023
@0utplay 0utplay requested a review from derklaro June 9, 2023 08:12
@0utplay 0utplay self-assigned this Jun 9, 2023
@github-actions
Copy link

Test Results

  47 files  ±0    47 suites  ±0   1m 10s ⏱️ -2s
322 tests ±0  322 ✔️ ±0  0 💤 ±0  0 ±0 
652 runs  ±0  652 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 504c3ac. ± Comparison against base commit daa3096.

@derklaro derklaro merged commit 0701978 into nightly Jun 15, 2023
6 checks passed
@derklaro derklaro deleted the npc-floating-item branch June 15, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: module An issue/pull request releated to one of the internal modules t: fix A pull request introducing a fix for a bug. v: 3.X This pull should be included in the 3.4 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants