Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add object serializers for all kinds of time types #1285

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

derklaro
Copy link
Member

@derklaro derklaro commented Aug 8, 2023

Motivation

There were multiple people in the past few days that tried to serialize a java.time class using the default object mapping system. At the moment this is not possible due to the lack of serializers for these types.

Modification

Add serializers for all java.time classes that are made to support the ISO-8601 standard. Other calendar systems (such as the Chinese one) are still not supported.

Result

Working with RPC and ISO-8601 java time types is now fully supported out of the box and no custom serializers are required anymore.

@derklaro derklaro added v: 4.X This pull should be included in the 4.0 release in: driver An issue/pull request releated to the driver module code t: improvement The pull request improves existing code a: api An issue/pull request that is related to api changes. labels Aug 8, 2023
@derklaro derklaro added this to the 4.0.0-RC10 milestone Aug 8, 2023
@derklaro derklaro requested a review from 0utplay August 8, 2023 11:22
@derklaro derklaro self-assigned this Aug 8, 2023
@derklaro derklaro merged commit 4ad48b5 into nightly Aug 8, 2023
7 checks passed
@derklaro derklaro deleted the time-object-serializer branch August 8, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: api An issue/pull request that is related to api changes. in: driver An issue/pull request releated to the driver module code t: improvement The pull request improves existing code v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants