Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update labymod module #1309

Merged
merged 5 commits into from
Oct 21, 2023
Merged

chore: update labymod module #1309

merged 5 commits into from
Oct 21, 2023

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented Sep 25, 2023

Motivation

Labymod released a new major version: 4.X. A lot of the labymod procotol features from LabyMod 3 were removed and therefore we should do the same.

Modification

Removed all outdated labymod protocol functions such as discord parties and invites.

Result

We only support features that are actually implemented in LabyMod 4

Other context

Fixes #1283

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release t: fix A pull request introducing a fix for a bug. in: module An issue/pull request releated to one of the internal modules labels Sep 25, 2023
@0utplay 0utplay added this to the 4.0.0-RC10 milestone Sep 25, 2023
@0utplay 0utplay self-assigned this Sep 25, 2023
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Test Results

  47 files  ±0    47 suites  ±0   1m 24s ⏱️ -3s
394 tests ±0  394 ✔️ ±0  0 💤 ±0  0 ±0 
724 runs  ±0  724 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 9403c9e. ± Comparison against base commit ec24887.

This pull request removes 27 and adds 27 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","this":"is","insane":"!"}}, PRETTY
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 16840, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [1] {test=test1, test2=test3}, class java.lang.String, class java.lang.String
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [23] 2023-08-22T14:23:54.679234906Z
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [24] 2023-08-22T14:15:34.679239206Z
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] 7PD9GSIC0QU0H8OFYGYEMF6S6, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] {test=123, test2=456}, class java.lang.String, class java.lang.Integer
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [38] 2023-08-22
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] 1465852859, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:f9f810b4-96d2-46f1-9db2-a4752eaa7769
…
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","hello":"world","this":"is"}}, PRETTY
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 27180, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [1] {test2=test3, test=test1}, class java.lang.String, class java.lang.String
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [23] 2023-09-26T08:48:20.890657169Z
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [24] 2023-09-26T08:40:00.890659769Z
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] DBQO0A2BGV19MF4OVBCP1RJ2V, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] {test2=456, test=123}, class java.lang.String, class java.lang.Integer
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [38] 2023-09-26
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] 124875809, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:24ed051f-0754-44ef-a484-82c1362fe5af
…

♻️ This comment has been updated with latest results.

@derklaro derklaro merged commit 102853c into nightly Oct 21, 2023
6 checks passed
@derklaro derklaro deleted the update-labymod-module branch October 21, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: module An issue/pull request releated to one of the internal modules t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labymod module no longer completely working
2 participants