-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update labymod module #1309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
This pull should be included in the 4.0 release
t: fix
A pull request introducing a fix for a bug.
in: module
An issue/pull request releated to one of the internal modules
labels
Sep 25, 2023
Test Results 47 files ±0 47 suites ±0 1m 24s ⏱️ -3s Results for commit 9403c9e. ± Comparison against base commit ec24887. This pull request removes 27 and adds 27 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
0utplay
force-pushed
the
update-labymod-module
branch
from
September 26, 2023 08:46
3c88e2e
to
9403c9e
Compare
derklaro
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: module
An issue/pull request releated to one of the internal modules
t: fix
A pull request introducing a fix for a bug.
v: 4.X
This pull should be included in the 4.0 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Labymod released a new major version: 4.X. A lot of the labymod procotol features from LabyMod 3 were removed and therefore we should do the same.
Modification
Removed all outdated labymod protocol functions such as discord parties and invites.
Result
We only support features that are actually implemented in LabyMod 4
Other context
Fixes #1283