feat: ignore non-existent worlds when choosing a free sign #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schucko1337
added
the
in: module
0utplay
added
v: 4.X
0utplay
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If multiple tasks are in the same group and the tasks use different world names, it is possible that the CloudSigns module selects signs that do not exist, therefore the services are never displayed. This PR ignores all signs that do not exist on the server.
Modification
Signs in unknown worlds are skipped.
Another "cleanupall" option has been added to the cloud signs command, which behaves like the old "cleanup".
The old "cleanup" option has been extended by an additional optional argument "world", which specifies the world in which the cleanup should take place.
Result
Only characters in existing worlds are considered.
Other context
https://discord.com/channels/325362837184577536/818777626663321671/1215677639709425756