Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 69 #102

Merged
merged 8 commits into from
Jul 28, 2023
Merged

fix Issue 69 #102

merged 8 commits into from
Jul 28, 2023

Conversation

nutsjian
Copy link
Collaborator

What is the purpose of the change

  • fix the selecto component selection issue

Related issues/PRs

Related issues: #69

Brief change log

  • clean code, remove useless code
  • fix SolidEditor selecto component's selection issue.

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@dlimeng
Copy link
Collaborator

dlimeng commented Jul 27, 2023

LGTM

Copy link
Collaborator

@15100399015 15100399015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem

@15100399015 15100399015 merged commit b19e91b into CloudOrc:dev Jul 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants