Dangerous code regarding parameter lifetime

[horde3d]

Passing the parameters by reference to the std::thread object probably will result in a crash for most users, if they don't take care that those parameters have to be valid and constant for the whole thread lifetime.

webdav-client-cpp/sources/client.cpp

Line 556 in 5a92c82

std::thread downloading([&]() { this->sync_download(remote_file, local_file, callback, std::move(progress)); });

Instead of capturing the parameters with a lambda expression it would be probably better to pass the parameters as a thread local copy, e.g. by passing the function parameters as parameters to the thread instance.

[rusdevops]

Thank you for your code review 👍