Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing export of Ec2Runner and Ec2RunnerProps #161

Closed
fwerkmeister opened this issue Nov 29, 2022 · 0 comments · Fixed by #162
Closed

Missing export of Ec2Runner and Ec2RunnerProps #161

fwerkmeister opened this issue Nov 29, 2022 · 0 comments · Fixed by #162

Comments

@fwerkmeister
Copy link
Contributor

With the last version Ec2Runners have been introduced. I just wanted to give it a try and came over a missing export of Ec2Runner and Ec2RunnerProps within the index.ts

import { Ec2Runner} from "@cloudsnorkel/cdk-github-runners";
lib/github-runners-stack.ts:15:3 - error TS2305: Module '"../node_modules/@cloudsnorkel/cdk-github-runners/lib"' has no exported member 'Ec2Runner'.

Seams the export is missing.
fwerkmeister pushed a commit to fwerkmeister/cdk-github-runners that referenced this issue Nov 29, 2022
fix: Add missing export for Ec2Runner
f76bbe9 
fixes CloudSnorkel#161
fwerkmeister pushed a commit to fwerkmeister/cdk-github-runners that referenced this issue Nov 29, 2022
fix: Add missing export for Ec2Runner
1c7bbfa 
fixes CloudSnorkel#161
@fwerkmeister fwerkmeister mentioned this issue Nov 29, 2022
Merged
@mergify mergify bot closed this as completed in #162 Nov 29, 2022
mergify bot pushed a commit that referenced this issue Nov 29, 2022
fix: Add missing export for Ec2Runner (#162)
2aae0e6 
fixes #161
@christophgysin christophgysin mentioned this issue Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add missing export for Ec2Runner fwerkmeister/cdk-github-runners
1 participant
@fwerkmeister