Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web-based interface to automatically setup GitHub app #6

Closed
kichik opened this issue May 20, 2022 · 2 comments · Fixed by #30
Closed

Web-based interface to automatically setup GitHub app #6

kichik opened this issue May 20, 2022 · 2 comments · Fixed by #30

Comments

@kichik
Copy link
Member

kichik commented May 20, 2022

We can create GitHub App from manifest. It doesn't include client id and secret, but are those truly required? Can we use API to generate them? It also doesn't install the app, but there is probably a way to direct the user to the right URL automatically. We can then collect the installation webhook event and save installation id from there.

There are security considerations with this. We definitely don't want to let anyone who can guess the URL attach itself to our service. But we want to keep it simple so authentication against Cognito or IdP is a bit too much. Maybe we can settle for a one time setup token that gets deleted once the installation is complete. It can be given to the user in the stack output or with another function like the status function.
@moltar
Copy link

moltar commented May 26, 2022

Might be helpful https://github.com/jogold/cloudstructs/tree/master/src/slack-app

@kichik
Copy link
Member Author

kichik commented May 27, 2022

Might be helpful https://github.com/jogold/cloudstructs/tree/master/src/slack-app

Thanks! I'll take a look.

kichik added a commit that referenced this issue Jun 1, 2022
@kichik
feat: simplify GitHub app installation
d225600 
1. Remove client id, client secret and installation id configuration
2. Get installation id from webhook event to support multiple installations
3. Make it possible to automate app creation with manifests as described in #6
4. Improve status function to list installations and test their authentication

BREAKING CHANGE: backup GitHub auth secret as it will be reset to its default value
@kichik kichik mentioned this issue Jun 1, 2022
Merged
mergify bot pushed a commit that referenced this issue Jun 1, 2022
@kichik
feat: simplify GitHub app installation (#25)
3570e63 
1. Remove client id, client secret, and installation id configuration
2. Get installation id from webhook event to support multiple installations
3. Make it possible to automate app creation with manifests as described in #6
4. Improve status function to list installations and test their authentication

BREAKING CHANGE: backup GitHub auth secret as it will be reset to its default value
kichik added a commit that referenced this issue Jun 4, 2022
@kichik
feat: Setup wizard for GitHub integration
96b0d42 
Provide an automated way to create GitHub app with manifests, or to set a personal token. This allows the user to easily install everything without manually editing secrets or copying around strings.

Closes #6
@kichik kichik mentioned this issue Jun 4, 2022
Merged
@mergify mergify bot closed this as completed in #30 Jun 4, 2022
mergify bot pushed a commit that referenced this issue Jun 4, 2022
@kichik
feat: Setup wizard for GitHub integration (#30)
38ce153 
Provide an automated way to create GitHub app with manifests, or to set a personal token. This allows the user to easily install everything without manually editing secrets or copying around strings.

Closes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Setup wizard for GitHub integration CloudSnorkel/cdk-github-runners
2 participants
@moltar @kichik