New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add option to enable logging on state machine #150
Conversation
I feel like it would be nicer if it shared the same logging style of other parts of the system. Other parts create the log stream for you and just request the retention period. Is there an importance here to using an existing log group? |
fine :) |
If we can get the log group name into the status function too, even better. |
333e89e
to
213590f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Did the status function not work out? Does it have no possible access to this log stream to display it?
@kichik |
Yeah ideally let's add some unit tests as this is not covered by the integration tests. Just something basic that makes sure the log group is included in the step function definition. Also, I'm sorry I missed it before, but other code doesn't let the user choose the log name. Unless there is a specific requirement for this here, let's remove that option. |
…lint formatting better. We should see if we can address the specific issues that it doesn't clean like spaces around curly brackets. But either way it should be a separate PR so the history is cleaner and easier to rea din the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
closes #148