Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump codebuild build images to latest #438

Closed
wants to merge 3 commits into from

Conversation

quad
Copy link
Contributor

@quad quad commented Oct 4, 2023

I know the comment says the version doesn't matter, but it kinda does for us since the newer versions bring in newer versions of BuildKit.

@quad quad changed the title Bump codebuild build images to latest chore(deps): Bump codebuild build images to latest Oct 4, 2023
@kichik
Copy link
Member

kichik commented Oct 4, 2023

AMAZON_LINUX_2_STANDARD_3_0 was added in CDK 2.78.0 with PR #25351. Our current minimum requirement is CDK 2.77.0. So the build fails with:

TSError: ⨯ Unable to compile TypeScript:
src/image-builders/codebuild.ts:192:45 - error TS2551: Property 'AMAZON_LINUX_2_STANDARD_3_0' does not exist on type 'typeof LinuxArmBuildImage'. Did you mean 'AMAZON_LINUX_2_STANDARD_1_0'?

192         return codebuild.LinuxArmBuildImage.AMAZON_LINUX_2_STANDARD_3_0;
                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~

Will AMAZON_LINUX_2_STANDARD_2_0 be enough, or do we need to upgrade?

Can you please also add a short description with a link or two as to why this is required? It would be good for anyone else in the future stumbling on the same issue.

@danny-fairly
Copy link

@kichik I'm also looking to get more recent versions of buildkit in the codebuild images. Is there any way to override/specify the Docker Version being used? Currently it looks to be pinned to "20.10.18".

@kichik
Copy link
Member

kichik commented Oct 20, 2023

@kichik I'm also looking to get more recent versions of buildkit in the codebuild images. Is there any way to override/specify the Docker Version being used? Currently it looks to be pinned to "20.10.18".

That was fixed with #431. I thought I released it already, but I didn't. 0.11.4 is on the way and has this fix.

@kichik
Copy link
Member

kichik commented Nov 30, 2023

@quad this breaks ARM64 builds. It seems like it's not installing BuildKit at all.

[Container] 2023/11/30 15:06:09.700961 Running command docker build --progress plain . -t "$REPO_URI"
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

unknown flag: --progress
See 'docker build --help'.

@quad
Copy link
Contributor Author

quad commented Dec 28, 2023

Resolved by #487

@quad quad closed this Dec 28, 2023
@quad quad deleted the patch-4 branch December 28, 2023 14:08
mergify bot pushed a commit that referenced this pull request Feb 19, 2024
Build and push SOCI indexes so Fargate can start our runners faster.

Technically only Fargate supports it now. But it's easier to just always build it. Plus ECS and Lambda may support it in the future. That's why we build it for all providers.

This commit also updates CodeBuild image builder to Amazon Linux 2023. Prior to this we were on Ubuntu for x64 and Amazon Linux 2 for arm64. Previous iterations of this PR required this for containerd, but the current one doesn't require it. Still I kept it here to keep the image build environment consistent between platforms.

Resolves #389
Relates #438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants