Add the zone parameter to create_subnet #101
Conversation
Adding the zone parameter to create_subnet
Zone parameter in Subnet create is compulsory
There was a problem hiding this comment.
Thanks for continuing your work on this. I've added a comment. The tests are also still failing: https://travis-ci.org/gvlproject/cloudbridge
| @@ -740,7 +740,7 @@ def find(self, name, limit=None, marker=None): | |||
| pass | |||
|
|
|||
| @abstractmethod | |||
| def create(self, name, network_id, cidr_block, zone=None): | |||
| def create(self, name, network_id, cidr_block, zone=zone): | |||
There was a problem hiding this comment.
This should just be a required parameter, with no default value, as follows:
def create(self, name, network_id, cidr_block, zone):
Removing the zone parameter from the providers
|
If you rebase your changes on top of this commit 18e3c04, the tests should pass. |
|
Does this mean that I have to create a new pull request on top of the new commit that you made? I haven't done rebasing before... |
|
You can just merge the That should create a merge commit. Ideally, you could then rebase this for a cleaner history but unless you're eager to learn the process, don't worry about it (and if you do decide to learn, push your changes first because with rebase there's a chance of messing up your local cone). |
|
@Dyex719 Are you planning to do more work on this (see here: #63 (comment)) or should we merge in the changes you've made so far? |
|
Sorry, I'm busy till 15th. I can only work on this after that. Is that okay? |
|
No worries, was just following up on this. |
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
===========================================
+ Coverage 38.66% 68.48% +29.81%
===========================================
Files 23 17 -6
Lines 4911 3167 -1744
Branches 380 299 -81
===========================================
+ Hits 1899 2169 +270
+ Misses 3005 946 -2059
- Partials 7 52 +45Continue to review full report at Codecov.
|
Adding the zone parameter to create_subnet