New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ipaddress instead of unmaintained py2-ipaddress #118
Conversation
And install it only for python<3.3 .
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=========================================
Coverage ? 59.13%
=========================================
Files ? 23
Lines ? 4892
Branches ? 459
=========================================
Hits ? 2893
Misses ? 1924
Partials ? 75 Continue to review full report at Codecov.
|
@nsoranzo Thanks, this looks great! I guess the newer requirement syntax doesn't work on pypy yet, but we can fix that when it eventually does. I think the build failures on openstack and azure are unrelated, because we've run into a quota issue on them. |
Everything works on PyPI, this is how I build and upload my Python packages:
You just need recent versions of |
I was thinking about PyPy, as in the jit compiler - I saw that an earlier commit had a newer requirements syntax, which I assume you removed because of PyPy? |
Ah, sorry, I misread! The problem is not PyPy (that I know of), but old It is also possible to support setuptools<18, if needed, with an ugly workaround as in https://gitlab.com/pycqa/flake8/blob/master/setup.py . |
That makes sense - thanks for the details. PEP508 looks really interesting! |
Also build universal wheels.
Both will help the Galaxy under Python3 project.