Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ipaddress instead of unmaintained py2-ipaddress #118

Merged
merged 2 commits into from Mar 27, 2018

Conversation

nsoranzo
Copy link
Contributor

Also build universal wheels.

Both will help the Galaxy under Python3 project.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@3645f20). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #118   +/-   ##
=========================================
  Coverage          ?   59.13%           
=========================================
  Files             ?       23           
  Lines             ?     4892           
  Branches          ?      459           
=========================================
  Hits              ?     2893           
  Misses            ?     1924           
  Partials          ?       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3645f20...296cfb9. Read the comment docs.

@nuwang nuwang merged commit f005723 into CloudVE:master Mar 27, 2018
@nuwang
Copy link
Contributor

nuwang commented Mar 27, 2018

@nsoranzo Thanks, this looks great! I guess the newer requirement syntax doesn't work on pypy yet, but we can fix that when it eventually does. I think the build failures on openstack and azure are unrelated, because we've run into a quota issue on them.

@nsoranzo
Copy link
Contributor Author

Everything works on PyPI, this is how I build and upload my Python packages:

$ python setup.py sdist
$ python setup.py bdist_wheel
$ twine upload dist/*

You just need recent versions of pip, setuptools, twine and wheel.

@nuwang
Copy link
Contributor

nuwang commented Mar 27, 2018

I was thinking about PyPy, as in the jit compiler - I saw that an earlier commit had a newer requirements syntax, which I assume you removed because of PyPy?

@nsoranzo
Copy link
Contributor Author

Ah, sorry, I misread! The problem is not PyPy (that I know of), but old setuptools: the extras_require syntax is understood by setuptools >=18, while the PEP 508 syntax I initially used is understood only by setuptools >=36.2 . See https://hynek.me/articles/conditional-python-dependencies/ for more details.

It is also possible to support setuptools<18, if needed, with an ugly workaround as in https://gitlab.com/pycqa/flake8/blob/master/setup.py .

@nuwang
Copy link
Contributor

nuwang commented Mar 27, 2018

That makes sense - thanks for the details. PEP508 looks really interesting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants