Fix issues with upload blob, blob url and snapshots #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seeing some weird things locally and going through each bit is taking a bit too long 馃槥
This new PR fixes issues with the blob - I also add to add the
Storage Blob Contributor
role in order to get the objects inside a storage bucket.Getting the signed URL was also broken so I fixed it in this PR. Creating a snapshot from a volume wasn't working anymore because
create_or_update
expects you to pass a snapshot class. This PR adds the Disk object to the API, but there are some issues, for example, I didn't yet figure out how to get the new tag into the snapshot so our fetching will be broken 馃槥A note on the
AzureBucketObject
, when we are listing the objects, Azure returns a BlobProperties, but when we are getting it returns the blobclient. The easiest way to handle this was to addself._blob_properties
to the class and use that instead