Allow users to create signed urls with write permissions #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was going to suggest |
nuwang
reviewed
Nov 30, 2021
|
I like writable! I’ll change it thank you! |
|
Finally got time to keep working on this and finished off the implementation of #293, I've manually tested this in GCP and AWS and works as expected. I don't have an OpenStack account so I can't test it fully and need to get new creds for Azure to test it with Azure but from the three Azure might work fine since its just a permissions thing that we need to pass when generating the URL 😄 ) |
nuwang
previously approved these changes
Dec 3, 2021
|
Thanks for making these changes so quickly @FabioRosado. I'll merge this in and prep for release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293
This is a draft PR to allow users to generate signed URLs with write permissions. I was a bit unsure on what to name the parameter, I was torn between:
Initially, I was implementing an ENUM so users could specify their permissions, would that be preferable? I decided against it after giving it some thought since perhaps accepting a bool would make it easier to work with the
generate_urlmethod, but I'm happy with either as long as we have some docs for it.One thing that is missing from this PR is testing, I'm planning to reuse the
test_generate_urltest that we have and push the content with the URL then check that it's there.So far I've tested this with GCP and seems to work fine, but I want to do a bit more manual testing as well