Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidied test and optimised object creation #65

Merged
merged 6 commits into from
Jan 10, 2021
Merged

Tidied test and optimised object creation #65

merged 6 commits into from
Jan 10, 2021

Conversation

Sam-Martin
Copy link
Collaborator

@Sam-Martin Sam-Martin commented Jan 6, 2021 •
edited
Loading

  • Reuse service definition objects via _get_resource_definitions to save on time spent reinstantiating identical objects
  • Only instantiate the default ServiceMapping from get_service_mapping if it's required.
  • Reduced number of regions tested from all to 3.

@Sam-Martin Sam-Martin added this to In progress in Ready for Use Jan 6, 2021
@Sam-Martin Sam-Martin changed the title Tidied up tests a litle Tidied test and optimised object creation Jan 7, 2021
@Sam-Martin Sam-Martin merged commit 612a922 into main Jan 10, 2021
Ready for Use automation moved this from In progress to Done Jan 10, 2021
@Sam-Martin Sam-Martin deleted the feature/test-tidy branch January 10, 2021 16:11
@Sam-Martin Sam-Martin mentioned this pull request Jan 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Ready for Use
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Sam-Martin