Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoreboard Support and API #66

Open
wants to merge 6 commits into
base: bleeding
Choose a base branch
from
Open

Scoreboard Support and API #66

wants to merge 6 commits into from

Conversation

lukeeey
Copy link
Member

@lukeeey lukeeey commented Sep 24, 2020

Originally created by RednedEpic at CloudburstMC/Nukkit#1420


This brings in a scoreboard API (and eventually a finished system to interact with /scoreboard commands) to Cloudburst. For the time being, this PR will mostly only cover support for scoreboards (with an API to do so) that are the equivalent of that of what can be done in vanilla Bedrock itself, however, this may also include some additions that are slightly beyond the scope of vanilla Bedrock, such as adding support for multiple criteria and teams.

I also did what other parts of the codebase have done and split up the API and implementation for the scoreboards themselves. There are some parts of the code (such as the static builder methods in the API classes) which directly call on the impl classes. However when Cloudburst eventually does split up the API and implementation, adding in some sort of builder provider should be quite easy to do.

What's left to do:

  • Scoreboard API
  • /scoreboard command (working on) - in another PR
  • Per-world scoreboards (for interacting with the scoreboard command) -in another PR
  • (?) Team and multiple criteria support (?)

MrReskill
MrReskill previously approved these changes Dec 30, 2020
@lukeeey lukeeey marked this pull request as ready for review January 24, 2021 20:04
@lukeeey
Copy link
Member Author

lukeeey commented Jan 24, 2021

I've removed the scoreboard command that i was working on (ill add it back in a future PR) and simply left the API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants