disabling auto-save doesen't work

[Sulfatezzz]

Actual Behavior

It's currently not possible to disable auto-save in nukkit.
Neither in-game or via plugin.

Steps to Reproduce

1. run command /save-off
2. place/destroy blocks
3. unload world (via plugin or restart server)
4. changes are still there

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[PetteriM1]

I think Nukkit saves worlds when it unloads them

[Sulfatezzz]

No I think it shouldn't. Take a look at

Level.java@404
It checks for autoSave statement before

public void close() {
        if (this.getAutoSave()) {
            this.save();
        }
        this.provider.close();
        this.provider = null;
        this.blockMetadata = null;
        this.temporalPosition = null;
        this.server.getLevels().remove(this.levelId);
        this.generators.clean();
    }

[bddvlpr]

I'm quite sure auto-save means the server should automatically save after a dedicated period of time, not on shutdown. Even though the close method gets called, it still gets saved on shutdown.