Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SubClientLoginSerializer_v291.java #215

Merged

Conversation

terryherbert
Copy link
Contributor

After investigating why Spilt Screen functionality was not functioning on GeyserMC, I discovered that the SubClientLogin message received from the Bedrock client could not be deserialize by SubClientLoginSerializer_v291.

The original code expected a JSONArray off the wire, however we were actually getting a JSONObject containing JSONArray when you get "chain".

Further investigation I discovered that this mirrors precisely what the LoginSerializer_v291, the only exception is that SubClientLogin message does not start with the protocol version.

I have updated the serialize method to mirror that of deserialize.

With these changes plus a some additional in GeyserMC works.

Fix serialization of SubClientLogin
@Alemiz112 Alemiz112 merged commit d14e484 into CloudburstMC:3.0 Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants