-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic vim bindings #314
Conversation
H/M/L to goto first/mid/last item in view X to delete character before the cursor v to toggle item selection Change goto first item from g to gg
I have fixed any known issues, removed debug logging and added documentation in the README. I think that should be it with the changes that i had in mind. If there is anything else please let me know. |
Other than that it looks good. I think with this framework, even the original bindings could be refactored to own file at some point. And perhaps even possibility for a implementation that implements customizable keybindings from a file. |
Yeah, that would be a good idea for the long term. Maybe i will look into this if i have more time available. We'll see. |
Looks good thanks |
Is this tested on Wayland? I'm on the latest version 0.6.14 with this feature and am not able to enter normal mode to test any of the differences offered with the setting. Another user reported the same problem (I'm also on Arch and Wayland). |
Can confirm it's working now. Could you add and (and maybe even ESC) to terminate bemenu in normal mode? The first two already work in insert mode but don't in vim mode. It feels strange to have to go back to insert mode just to terminate bemenu.
It would also be nice to have B,E,f,t,F,T work but I assume they are much more involved. A random idea for improvement would be an indicator for normal mode (e.g. change prompt color, cursor style, etc.). Thanks for your work. |
I have added basic vim bindings for me a while ago. I was wondering if it would be something you are interested in having in the "main project" @Cloudef . I am happy to make any adjustments as needed (like removing the logs and adding keybinds to the README).