Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border fixes (fixes: #399) #407

Merged
merged 6 commits into from
Jul 7, 2024
Merged

Conversation

Xgames123
Copy link

@Xgames123 Xgames123 commented Jun 18, 2024

  • fixed border with corner radius not clipping bg
  • fixed corners being too thick
  • fixed border looking weird when height/width is less than corner radius
  • renamed bm_cairo_draw_rounded_path to bm_cairo_rounded_path because it was not actually drawing the path and only setting it as the shape in cairo.

I checked if the changes work with --fixed-height, --list, --line-height on x11 and wayland.

Also what is the reason that anti-aliasing is explicitly disabled in the code?

ldev added 4 commits June 18, 2024 17:53
fixed border with corner radius not clipping bg
fixed corners being too thick
fixed border looking weird when height/width is less than corner radius
because it is not actualy drawing and now it is also used for clip
@Cloudef
Copy link
Owner

Cloudef commented Jun 18, 2024

Not sure about the anti-alias, it was introduced in commit 877ca82

@Cloudef
Copy link
Owner

Cloudef commented Jul 7, 2024

Thanks.

@Cloudef Cloudef merged commit 1201340 into Cloudef:master Jul 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants