Mark global wayland constant extern #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without `extern`, the changed lines are not declarations, but "tentative definitions" (according to GCC man page, option `-fcommon`). When specified in a header file that is included in more than one `.c` file, these result in linking failure unless `-fcommon` is specified. GCC 10 changed the default from `-fcommon` to `-fno-common`, and as such the previous code no longer links properly. With `extern`, these lines are considered declarations, and the linking proceeds successfully.
|
Thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
extern, the changed lines are not declarations, but "tentative definitions" (according to GCC man page, option-fcommon). When specified in a header file that is included in more than one.cfile, these result in linking failure unless-fcommonis specified.GCC 10 changed the default from
-fcommonto-fno-common, and as such the previous code no longer links properly.With
extern, these lines are considered declarations, and the linking proceeds successfully.