Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File share UI work for sharing Location #525

Closed
sumairasaeed opened this issue Feb 22, 2017 · 5 comments
Closed

File share UI work for sharing Location #525

sumairasaeed opened this issue Feb 22, 2017 · 5 comments
Labels
enhancement High Resolved

Comments

@sumairasaeed
Copy link
Contributor

Here we will do UI work needed for sharing location as file attachment
@jekram jekram mentioned this issue Feb 27, 2017
Closed
@sumairasaeed
Copy link
Contributor Author

Worked on this. Created UI for prompting user to share location. Created UI component to be shown on chat window. Remaining is to show image/map location and code its class implementation

@jekram
Copy link
Contributor

jekram commented Mar 1, 2017

Thanks for the update

@sumairasaeed
Copy link
Contributor Author

Completed work of showing map on sender's side. At first, there were issues in showing map with marked location but then added GMSMapView as subview and it is shown now. Remaining part is to show on receiver's side.

@sumairasaeed
Copy link
Contributor Author

This has been completed now. Tested with iOS and android both.

@jekram
Copy link
Contributor

jekram commented Mar 2, 2017

Great job Thanks

@jekram jekram closed this as completed Mar 2, 2017
@sumairasaeed sumairasaeed mentioned this issue Apr 20, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement High Resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jekram @sumairasaeed