Brave new world #164
Merged
Brave new world #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite into a core library with simple methods and an abstraction layer on top of the backend system. The following backends are implemented * Memory (for testing; only works within a single JVM) * ZooKeeper (proof-of-concept implementation of the backend) The following libraries are created: * Service discovery library This brings the overall functionality on par with 2.x with a few exceptions: * Locking isn't implemented. That did not work for the old library so there's no real change in functionality * It isn't possible to query *everything* from a client. This will be addressed in another commit (or just ignored completely since the backends offers this in some shape or form) * It isn't possible to resolve coordinates partially, f.e. finding "logserver" when your own coordinate is "service.tag.region"; "logserver" should resolve to "logserver.tag.region". This will be solved in a later commit by making a separate resolver class that creates service coordinates based on existing coordinates.
* Javadoc: Spelling errors, inconsistent puncutation * Tests: assertThat(<something>, is(equalTo(<other>))) rather than assertThat(<something>.equals(<other>), is(false)) * Use Array.deepEquals() in CloudnamePath
5ms is a little bit too quick for Core i5 and lesser processors. Be nice and increase the time to 100ms. This is a lot so most backends should (or rather, *must*) manage this.
|
After a lucid moment last night (you know the drill) I'll add a listener to the returned LeaseHandle instance that gets a callback whenever the backend connection is lost and code in the service library to reacquire the lease when the connection is restored. Quite important stuff and not very nice to start thinking about 2 am in the night. The last version missed this feature completely as well. Bugger. |
Use a connection URL to create backends via the BackendManager class. This makes for a much easier way of creating different backends.
Use forEach() - much cleaner implementation.
stalehd
added a commit
that referenced
this pull request
Dec 15, 2015
Brave new world (beta). Complete rewrite of the library and zero backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite into a core library with simple methods and an abstraction layer on
top of the backend system.
The following backends are implemented
The following libraries are created:
This brings the overall functionality on par with 2.x with a few exceptions:
there's no real change in functionality
addressed in another commit (or just ignored completely since the
backends offers this in some shape or form)
"logserver" when your own coordinate is "service.tag.region";
"logserver" should resolve to "logserver.tag.region". This will
be solved in a later commit by making a separate resolver class that
creates service coordinates based on existing coordinates.