Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opposite if-conditional in org.fog.placement.MicroservicesController::init() methods #5

Open
kapamaroo opened this issue Jan 29, 2022 · 0 comments · May be fixed by #7
Open

Opposite if-conditional in org.fog.placement.MicroservicesController::init() methods #5

kapamaroo opened this issue Jan 29, 2022 · 0 comments · May be fixed by #7

Comments

@kapamaroo
Copy link

Hello,

In the org.fog.placement.MicroservicesController class, the two init() methods operate differently on the Config.ENABLE_STATIC_CLUSTERING value.

In particular:

org.fog.placement.MicroservicesController::init() checks for:
if (Config.ENABLE_STATIC_CLUSTERING)

where

org.fog.placement.MicroservicesController::init(Map<Integer, List> monitored) checks the opposite:

if (!Config.ENABLE_STATIC_CLUSTERING)

Looking at the rest of the implementation, it seems likely a typo in one of them. In this case, which one is the "correct" one?
On the other hand, if this is intentional, could you elaborate the reasoning behind this difference between the two methods?

Thanks,
Emmanouil Maroudas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant